Code review practices - Constructive feedback

Providing objective feedback on the code is very effective outcome, at times you may find the code to have some obvious issues that might irritate you as reviewer, however it is important to be specific about feedback and provide it in a constructive way. e.g. Instead of "This code is horrible" saying something like "consider refactoring the additions into a separate function to make it more readable"

Point out what was good in reivew before pointing shortcomings

Provide information e.g. URLS, pointers to manpages etc. when suggesting changes

Follow a line of questioning e.g. have you considered approach A... instead of saying "You forgot A", it should be about the code not the person.

Mark essential changes from optional suggestions clearly.